{"id":2578,"date":"2024-08-13T23:42:00","date_gmt":"2024-08-13T15:42:00","guid":{"rendered":"https:\/\/systw.net\/note\/?p=2578"},"modified":"2025-08-14T10:35:34","modified_gmt":"2025-08-14T02:35:34","slug":"sc-logic-errors","status":"publish","type":"post","link":"https:\/\/systw.net\/note\/archives\/2578","title":{"rendered":"SC Logic Errors"},"content":{"rendered":"\n<p>\u908f\u8f2f\u932f\u8aa4\uff08Logic Errors\uff09\uff0c\u4e5f\u7a31\u70ba\u696d\u52d9\u908f\u8f2f\u6f0f\u6d1e\uff0c\u662f\u667a\u80fd\u5408\u7d04\u4e2d\u7684\u4e00\u7a2e\u96b1\u6027\u7f3a\u9677\u3002\u9019\u985e\u932f\u8aa4\u767c\u751f\u5728\u5408\u7d04\u7684\u7a0b\u5f0f\u78bc\u908f\u8f2f\u8207\u5176\u9810\u671f\u884c\u70ba\u4e0d\u4e00\u81f4\u6642\u3002\u908f\u8f2f\u932f\u8aa4\u53ef\u80fd\u4ee5\u591a\u7a2e\u5f62\u5f0f\u51fa\u73fe\uff0c\u4f8b\u5982\uff1a<\/p>\n\n\n\n<ul class=\"wp-block-list\">\n<li><strong>\u734e\u52f5\u5206\u914d\u932f\u8aa4<\/strong>\uff1a\u5728\u5206\u914d\u734e\u52f5\u6642\u8a08\u7b97\u932f\u8aa4\uff0c\u5c0e\u81f4\u4e0d\u516c\u5e73\u7684\u5206\u914d\u3002<\/li>\n\n\n\n<li><strong>\u4e0d\u7576\u7684\u4ee3\u5e63\u751f\u6210<\/strong>\uff1a\u672a\u53d7\u63a7\u5236\u6216\u932f\u8aa4\u7684\u4ee3\u5e63\u751f\u6210\u908f\u8f2f\uff0c\u5141\u8a31\u7121\u9650\u6216\u975e\u9810\u671f\u7684\u4ee3\u5e63\u751f\u6210\u3002<\/li>\n\n\n\n<li><strong>\u501f\u8cb8\u6c60\u4e0d\u5e73\u8861<\/strong>\uff1a\u5b58\u6b3e\u548c\u63d0\u6b3e\u8ffd\u8e64\u932f\u8aa4\uff0c\u5c0e\u81f4\u8cc7\u91d1\u6c60\u5132\u5099\u4e0d\u4e00\u81f4\u3002<\/li>\n<\/ul>\n\n\n\n<p>\u9019\u4e9b\u6f0f\u6d1e\u901a\u5e38\u96b1\u85cf\u5728\u5408\u7d04\u7684\u908f\u8f2f\u4e2d\uff0c\u96e3\u4ee5\u5bdf\u89ba\uff0c\u9700\u4ed4\u7d30\u6aa2\u67e5\u624d\u80fd\u767c\u73fe\u3002<\/p>\n\n\n\n<h4 class=\"wp-block-heading\">\u7bc4\u4f8b\uff08\u5b58\u5728\u6f0f\u6d1e\u7684\u5408\u7d04\uff09<\/h4>\n\n\n\n<p>\u4ee5\u4e0b\u662f\u4e00\u500b\u5b58\u5728\u908f\u8f2f\u932f\u8aa4\u7684\u667a\u80fd\u5408\u7d04\u7bc4\u4f8b\uff1a<\/p>\n\n\n\n<pre class=\"wp-block-code\"><code>\/\/ SPDX-License-Identifier: MIT\npragma solidity ^0.8.0;\n\ncontract Solidity_LogicErrors {\n    mapping(address =&gt; uint256) public userBalances;\n    uint256 public totalLendingPool;\n\n    function deposit() public payable {\n        userBalances&#91;msg.sender] += msg.value;\n        totalLendingPool += msg.value;\n    }\n\n    function withdraw(uint256 amount) public {\n        require(userBalances&#91;msg.sender] &gt;= amount, \"Insufficient balance\");\n\n        <mark style=\"background-color:rgba(0, 0, 0, 0)\" class=\"has-inline-color has-vivid-red-color\">\/\/ Faulty calculation: Incorrectly reducing the user's balance without updating the total lending pool<\/mark>\n        userBalances&#91;msg.sender] -= amount;\n\n        payable(msg.sender).transfer(amount);\n    }\n\n    function mintReward(address to, uint256 rewardAmount) public {\n        <mark style=\"background-color:rgba(0, 0, 0, 0)\" class=\"has-inline-color has-vivid-red-color\">\/\/ Faulty minting logic: Reward amount not validated<\/mark>\n        userBalances&#91;to] += rewardAmount;\n    }\n}<\/code><\/pre>\n\n\n\n<p><strong>\u6f0f\u6d1e\u5206\u6790<\/strong>\uff1a<\/p>\n\n\n\n<ol class=\"wp-block-list\">\n<li><strong>\u63d0\u6b3e\u529f\u80fd<\/strong>\uff1a\u5728 <code>withdraw<\/code> \u51fd\u6578\u4e2d\uff0c\u50c5\u66f4\u65b0\u4e86\u7528\u6236\u7684\u9918\u984d (<code>userBalances<\/code>)\uff0c\u4f46\u672a\u540c\u6b65\u6e1b\u5c11\u7e3d\u8cc7\u91d1\u6c60 (<code>totalLendingPool<\/code>)\u3002\u9019\u5c0e\u81f4\u8cc7\u91d1\u6c60\u7684\u7e3d\u984d\u8207\u5be6\u969b\u9918\u984d\u4e0d\u7b26\uff0c\u53ef\u80fd\u9020\u6210\u8cc7\u91d1\u6c60\u986f\u793a\u7684\u8cc7\u91d1\u9ad8\u65bc\u5be6\u969b\u53ef\u7528\u8cc7\u91d1\u3002<\/li>\n\n\n\n<li><strong>\u734e\u52f5\u751f\u6210\u529f\u80fd<\/strong>\uff1a<code>mintReward<\/code> \u51fd\u6578\u672a\u5c0d <code>rewardAmount<\/code> \u9032\u884c\u4efb\u4f55\u9a57\u8b49\uff0c\u53ef\u80fd\u5141\u8a31\u751f\u6210\u4efb\u610f\u6578\u91cf\u7684\u4ee3\u5e63\uff0c\u5c0e\u81f4\u4ee3\u5e63\u4f9b\u61c9\u81a8\u8139\u3002<\/li>\n<\/ol>\n\n\n\n<p><\/p>\n\n\n\n<p><\/p>\n\n\n\n<h4 class=\"wp-block-heading\">\u5f71\u97ff<\/h4>\n\n\n\n<p>\u908f\u8f2f\u932f\u8aa4\u53ef\u80fd\u5c0e\u81f4\u667a\u80fd\u5408\u7d04\u884c\u70ba\u7570\u5e38\uff0c\u751a\u81f3\u5b8c\u5168\u7121\u6cd5\u4f7f\u7528\uff0c\u5177\u9ad4\u5f71\u97ff\u5305\u62ec\uff1a<\/p>\n\n\n\n<ol class=\"wp-block-list\">\n<li><strong>\u8cc7\u91d1\u640d\u5931<\/strong>\uff1a\u932f\u8aa4\u7684\u734e\u52f5\u5206\u914d\u6216\u8cc7\u91d1\u6c60\u4e0d\u5e73\u8861\u53ef\u80fd\u5c0e\u81f4\u5408\u7d04\u8cc7\u91d1\u88ab\u8017\u76e1\u3002<\/li>\n\n\n\n<li><strong>\u904e\u91cf\u4ee3\u5e63\u751f\u6210<\/strong>\uff1a\u7121\u9650\u5236\u7684\u4ee3\u5e63\u751f\u6210\u6703\u7a00\u91cb\u4ee3\u5e63\u50f9\u503c\uff0c\u7834\u58de\u7528\u6236\u4fe1\u4efb\u3002<\/li>\n\n\n\n<li><strong>\u904b\u4f5c\u5931\u6557<\/strong>\uff1a\u5408\u7d04\u7121\u6cd5\u57f7\u884c\u9810\u671f\u529f\u80fd\uff0c\u5f71\u97ff\u7528\u6236\u548c\u5229\u76ca\u76f8\u95dc\u8005\u7684\u64cd\u4f5c\u3002<\/li>\n<\/ol>\n\n\n\n<p>\u9019\u4e9b\u5f8c\u679c\u53ef\u80fd\u5c0e\u81f4\u91cd\u5927\u7684\u8ca1\u52d9\u548c\u904b\u71df\u640d\u5931\u3002<\/p>\n\n\n\n<h4 class=\"wp-block-heading\">\u4fee\u5fa9\u65b9\u6cd5<\/h4>\n\n\n\n<p>\u70ba\u907f\u514d\u908f\u8f2f\u932f\u8aa4\uff0c\u958b\u767c\u8005\u61c9\u63a1\u53d6\u4ee5\u4e0b\u63aa\u65bd\uff1a<\/p>\n\n\n\n<ol class=\"wp-block-list\">\n<li><strong>\u5168\u9762\u6e2c\u8a66<\/strong>\uff1a\u7de8\u5beb\u6db5\u84cb\u6240\u6709\u696d\u52d9\u908f\u8f2f\u5834\u666f\u7684\u6e2c\u8a66\u7528\u4f8b\uff0c\u78ba\u4fdd\u7a0b\u5f0f\u78bc\u884c\u70ba\u7b26\u5408\u9810\u671f\u3002<\/li>\n\n\n\n<li><strong>\u7a0b\u5f0f\u78bc\u5be9\u67e5\u8207\u5be9\u8a08<\/strong>\uff1a\u9032\u884c\u5fb9\u5e95\u7684\u7a0b\u5f0f\u78bc\u5be9\u67e5\u548c\u7b2c\u4e09\u65b9\u5be9\u8a08\uff0c\u8b58\u5225\u4e26\u4fee\u5fa9\u6f5b\u5728\u908f\u8f2f\u932f\u8aa4\u3002<\/li>\n\n\n\n<li><strong>\u660e\u78ba\u6587\u4ef6<\/strong>\uff1a\u8a18\u9304\u6bcf\u500b\u529f\u80fd\u548c\u6a21\u7d44\u7684\u9810\u671f\u884c\u70ba\uff0c\u4e26\u8207\u5be6\u969b\u5be6\u73fe\u9032\u884c\u5c0d\u6bd4\uff0c\u78ba\u4fdd\u4e00\u81f4\u6027\u3002<\/li>\n\n\n\n<li><strong>\u9632\u8b77\u63aa\u65bd<\/strong>\uff1a<\/li>\n<\/ol>\n\n\n\n<ul class=\"wp-block-list\">\n<li>\u4f7f\u7528\u5b89\u5168\u7684\u6578\u5b78\u5eab\uff08\u5982 OpenZeppelin \u7684 SafeMath\uff09\u4f86\u907f\u514d\u8a08\u7b97\u932f\u8aa4\u3002<\/li>\n\n\n\n<li>\u5728\u4ee3\u5e63\u751f\u6210\u6642\u52a0\u5165\u9069\u7576\u7684\u6aa2\u67e5\u548c\u9650\u5236\u3002<\/li>\n\n\n\n<li>\u8a2d\u8a08\u53ef\u5be9\u8a08\u7684\u734e\u52f5\u5206\u914d\u6f14\u7b97\u6cd5\u3002<\/li>\n<\/ul>\n\n\n\n<h4 class=\"wp-block-heading\">\u4fee\u5fa9\u5f8c\u7684\u7bc4\u4f8b\u5408\u7d04<\/h4>\n\n\n\n<p>\u4ee5\u4e0b\u662f\u4fee\u5fa9\u4e86\u908f\u8f2f\u932f\u8aa4\u7684\u5408\u7d04\u7bc4\u4f8b\uff1a<\/p>\n\n\n\n<pre class=\"wp-block-code\"><code>\/\/ SPDX-License-Identifier: MIT\npragma solidity ^0.8.0;\n\ncontract Solidity_LogicErrors {\n    mapping(address =&gt; uint256) public userBalances;\n    uint256 public totalLendingPool;\n\n    function deposit() public payable {\n        userBalances&#91;msg.sender] += msg.value;\n        totalLendingPool += msg.value;\n    }\n\n    function withdraw(uint256 amount) public {\n        require(userBalances&#91;msg.sender] &gt;= amount, \"Insufficient balance\");\n\n        userBalances&#91;msg.sender] -= amount;\n        <mark style=\"background-color:rgba(0, 0, 0, 0)\" class=\"has-inline-color has-vivid-red-color\">totalLendingPool -= amount;<\/mark>\n        <mark style=\"background-color:rgba(0, 0, 0, 0)\" class=\"has-inline-color has-vivid-red-color\">\/\/ Correctly reducing the user's balance and updating the total lending pool<\/mark>\n\n        payable(msg.sender).transfer(amount);\n    }\n\n    function mintReward(address to, uint256 rewardAmount) public {\n        <mark style=\"background-color:rgba(0, 0, 0, 0)\" class=\"has-inline-color has-vivid-red-color\">require(rewardAmount &gt; 0, \"Reward amount must be positive\");<\/mark>\n        <mark style=\"background-color:rgba(0, 0, 0, 0)\" class=\"has-inline-color has-vivid-red-color\">\/\/ Safeguarded minting logic<\/mark>\n\n        userBalances&#91;to] += rewardAmount;\n    }\n}<\/code><\/pre>\n\n\n\n<p><strong>\u4fee\u5fa9\u5167\u5bb9<\/strong>\uff1a<\/p>\n\n\n\n<ol class=\"wp-block-list\">\n<li><strong>\u63d0\u6b3e\u529f\u80fd<\/strong>\uff1a\u5728 <code>withdraw<\/code> \u51fd\u6578\u4e2d\uff0c\u65b0\u589e\u4e86\u5c0d <code>totalLendingPool<\/code> \u7684\u66f4\u65b0\uff0c\u78ba\u4fdd\u8cc7\u91d1\u6c60\u7e3d\u984d\u8207\u7528\u6236\u9918\u984d\u540c\u6b65\u3002\n<ul class=\"wp-block-list\">\n<li>\u65b0\u589e\u7a0b\u5f0f\u78bc\uff1a<mark style=\"background-color:rgba(0, 0, 0, 0)\" class=\"has-inline-color has-vivid-red-color\"><code>totalLendingPool -= amount;<\/code><\/mark>\/\/ \u6b63\u78ba\u66f4\u65b0\u7528\u6236\u9918\u984d\u548c\u7e3d\u8cc7\u91d1\u6c60<\/li>\n<\/ul>\n<\/li>\n\n\n\n<li><strong>\u734e\u52f5\u751f\u6210\u529f\u80fd<\/strong>\uff1a\u5728 <code>mintReward<\/code> \u51fd\u6578\u4e2d\uff0c\u52a0\u5165\u4e86\u5c0d <code>rewardAmount<\/code> \u7684\u6b63\u6578\u6aa2\u67e5\uff0c\u907f\u514d\u7121\u6548\u6216\u60e1\u610f\u7684\u4ee3\u5e63\u751f\u6210\u3002\n<ul class=\"wp-block-list\">\n<li>\u65b0\u589e\u7a0b\u5f0f\u78bc\uff1a <mark style=\"background-color:rgba(0, 0, 0, 0)\" class=\"has-inline-color has-vivid-red-color\"><code>require(rewardAmount &gt; 0, \"Reward amount must be positive\");<\/code><\/mark>\/\/ \u5b89\u5168\u7684\u751f\u6210\u908f\u8f2f\uff0c\u78ba\u4fdd\u734e\u52f5\u91d1\u984d\u6709\u6548<\/li>\n<\/ul>\n<\/li>\n<\/ol>\n\n\n\n<h4 class=\"wp-block-heading\">\u7e3d\u7d50<\/h4>\n\n\n\n<p>\u908f\u8f2f\u932f\u8aa4\u662f\u667a\u80fd\u5408\u7d04\u958b\u767c\u4e2d\u5e38\u898b\u4f46\u5371\u96aa\u7684\u554f\u984c\uff0c\u53ef\u80fd\u5c0e\u81f4\u8cc7\u91d1\u640d\u5931\u3001\u4ee3\u5e63\u4f9b\u61c9\u81a8\u8139\u6216\u5408\u7d04\u529f\u80fd\u5931\u6548\u3002\u900f\u904e\u5168\u9762\u7684\u6e2c\u8a66\u3001\u7a0b\u5f0f\u78bc\u5be9\u67e5\u3001\u6587\u4ef6\u8a18\u9304\u548c\u9632\u8b77\u63aa\u65bd\uff0c\u958b\u767c\u8005\u53ef\u4ee5\u6709\u6548\u6e1b\u5c11\u908f\u8f2f\u932f\u8aa4\u7684\u767c\u751f\uff0c\u78ba\u4fdd\u5408\u7d04\u7684\u5b89\u5168\u6027\u548c\u53ef\u9760\u6027\u3002<\/p>\n\n\n\n<p><\/p>\n","protected":false},"excerpt":{"rendered":"<p>\u908f\u8f2f\u932f\u8aa4\uff08Logic Errors\uff09\uff0c\u4e5f\u7a31\u70ba\u696d\u52d9\u908f\u8f2f\u6f0f\u6d1e\uff0c\u662f &#8230;<\/p>\n","protected":false},"author":1,"featured_media":0,"comment_status":"closed","ping_status":"closed","sticky":false,"template":"","format":"standard","meta":{"fifu_image_url":"","fifu_image_alt":"","_jetpack_memberships_contains_paid_content":false,"footnotes":"","jetpack_publicize_message":"","jetpack_publicize_feature_enabled":true,"jetpack_social_post_already_shared":false,"jetpack_social_options":{"image_generator_settings":{"template":"highway","default_image_id":0,"enabled":false},"version":2}},"categories":[371],"tags":[],"class_list":["post-2578","post","type-post","status-publish","format-standard","hentry","category-web3-security"],"jetpack_publicize_connections":[],"jetpack_featured_media_url":"","jetpack_sharing_enabled":true,"_links":{"self":[{"href":"https:\/\/systw.net\/note\/wp-json\/wp\/v2\/posts\/2578","targetHints":{"allow":["GET"]}}],"collection":[{"href":"https:\/\/systw.net\/note\/wp-json\/wp\/v2\/posts"}],"about":[{"href":"https:\/\/systw.net\/note\/wp-json\/wp\/v2\/types\/post"}],"author":[{"embeddable":true,"href":"https:\/\/systw.net\/note\/wp-json\/wp\/v2\/users\/1"}],"replies":[{"embeddable":true,"href":"https:\/\/systw.net\/note\/wp-json\/wp\/v2\/comments?post=2578"}],"version-history":[{"count":2,"href":"https:\/\/systw.net\/note\/wp-json\/wp\/v2\/posts\/2578\/revisions"}],"predecessor-version":[{"id":2606,"href":"https:\/\/systw.net\/note\/wp-json\/wp\/v2\/posts\/2578\/revisions\/2606"}],"wp:attachment":[{"href":"https:\/\/systw.net\/note\/wp-json\/wp\/v2\/media?parent=2578"}],"wp:term":[{"taxonomy":"category","embeddable":true,"href":"https:\/\/systw.net\/note\/wp-json\/wp\/v2\/categories?post=2578"},{"taxonomy":"post_tag","embeddable":true,"href":"https:\/\/systw.net\/note\/wp-json\/wp\/v2\/tags?post=2578"}],"curies":[{"name":"wp","href":"https:\/\/api.w.org\/{rel}","templated":true}]}}